[webkit-reviews] review requested: [Bug 99392] Creating a String from an NSString should check for all 8 bit strings : [Attachment 169039] Updated Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 99392: Creating a String from an NSString should check for all 8 bit
strings
https://bugs.webkit.org/show_bug.cgi?id=99392

Attachment 169039: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=169039&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
It appears that these NSStrings are used in network responses among other
places.  They appear to be created by Core Foundation code.

Found a way for CFStringGetBytes() to return an 8 bit Latin1 string that we can
use directly.  No need to check for 8 bit characters.  Again in my simple
browsing test this worked every time.

If I need to check for all 8 bit characters in the future, I think modifying
and renaming ASCIIFastPath.h to CharacterFastPath.h is the way to go.