[webkit-reviews] review granted: [Bug 99478] Init timeout flag in ResourceErrorMac : [Attachment 169007] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 99478: Init timeout flag in ResourceErrorMac
https://bugs.webkit.org/show_bug.cgi?id=99478

Attachment 169007: Patch
https://bugs.webkit.org/attachment.cgi?id=169007&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169007&action=review


OK. There are still weird cases remaining (like what happens when one calls
setIsTimeout() and then round-trips the error object via NSError or WebKit2
IPC), but that's true of many things in ResourceError class.

> Source/WebCore/platform/network/mac/ResourceErrorMac.mm:99
> +    if (!m_isNull)
> +	   m_isTimeout = [m_platformError.get() code] == NSURLErrorTimedOut;

The null check is not strictly necessary - sending messages to null receivers
generally works in Objective-C (unconditionally works when returned type is an
integer).