[webkit-reviews] review granted: [Bug 99488] Fix a bug that we are using scaled damage rect for plugins inside an iframe : [Attachment 169000] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Min Qin <qinmin at chromium.org>'s
request for review:
Bug 99488: Fix a bug that we are using scaled damage rect for plugins inside an
iframe
https://bugs.webkit.org/show_bug.cgi?id=99488

Attachment 169000: Patch
https://bugs.webkit.org/attachment.cgi?id=169000&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169000&action=review


Can we write a test for this change?

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:142
>      IntRect windowRect =
> -	   IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect)));

> +	  
IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect).location()),
enclosingIntRect(scaledDamageRect).size());

Can we change this to only call enclosingIntRect(scaledDamageRect) once?  Also,
there's no reason to have a line break after the =