[webkit-reviews] review granted: [Bug 99435] MediaStream API: Add the chromium API for RTCDataChannel : [Attachment 168898] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 99435: MediaStream API: Add the chromium API for RTCDataChannel
https://bugs.webkit.org/show_bug.cgi?id=99435

Attachment 168898: Patch
https://bugs.webkit.org/attachment.cgi?id=168898&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168898&action=review


> Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h:71
> +    // RTCDataChannel
> +    virtual bool openDataChannel(const WebRTCDataChannel&) { return false; }

> +    virtual bool sendStringData(const WebRTCDataChannel&, const WebString&)
{ return false; }
> +    virtual bool sendRawData(const WebRTCDataChannel&, const char*, size_t)
{ return false; }
> +    virtual void closeDataChannel(const WebRTCDataChannel&) { }

The relationship between the PeerConnectionHandler and the DataChannel are
slightly strange.  The data channel seems to represent the WebKit side of the
channel and you're using PeerConnectionHandler as the embedder endpoint.  I
would have expected the DataChannel to have more a of a send/didReceive sort of
API, but this approach seems ok too.