[webkit-reviews] review granted: [Bug 86048] [Texmap] Refactor TextureMapperShaderManager to be clearer : [Attachment 167672] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 86048: [Texmap] Refactor TextureMapperShaderManager to be clearer
https://bugs.webkit.org/show_bug.cgi?id=86048

Attachment 167672: Patch
https://bugs.webkit.org/attachment.cgi?id=167672&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167672&action=review


Nice, I just have a few small suggestions.

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:56
> +    String log = m_context->getShaderInfoLog(m_vertexShader);
> +    printf("Vertex shader log: %s\n", log.utf8().data());
> +    log = m_context->getShaderInfoLog(m_fragmentShader);
> +    printf("Fragment shader log: %s\n", log.utf8().data());
> +    log = m_context->getProgramInfoLog(m_id);
> +    printf("Program log: %s\n", log.utf8().data());

It probably makes sense to use the WebCore log facilities here.

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:109
> +#define STRINGIFY(...) #__VA_ARGS__

This is a nit, but it would look a little bit cleaner if this was at the top of
the file.