[webkit-reviews] review granted: [Bug 99460] Implement the Selector argument to RTCPeerConnection.getStats : [Attachment 168946] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Harald Alvestrand <hta at google.com>'s
request for review:
Bug 99460: Implement the Selector argument to RTCPeerConnection.getStats
https://bugs.webkit.org/show_bug.cgi?id=99460

Attachment 168946: Patch
https://bugs.webkit.org/attachment.cgi?id=168946&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168946&action=review


This patch looks good.	Tommy and I have some very minor style issues that we
should clear up before landing.

> Source/Platform/chromium/public/WebRTCStatsRequest.h:89
> +    WEBKIT_EXPORT bool hasSelector() const;
> +
> +    WEBKIT_EXPORT const WebMediaStreamDescriptor stream() const;
> +
> +    WEBKIT_EXPORT const WebMediaStreamComponent component() const;

I might have added some comments explaining the relationship between these
functions.