[webkit-reviews] review denied: [Bug 98728] [Texmap] Swizzling BGRA to RGBA in temp buffer while USE(TEXMAP_OPENGL_ES_2) : [Attachment 168839] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Hyungchan Kim
<hyungchan2.kim at lge.com>'s request for review:
Bug 98728: [Texmap] Swizzling BGRA to RGBA in temp buffer while
USE(TEXMAP_OPENGL_ES_2)
https://bugs.webkit.org/show_bug.cgi?id=98728

Attachment 168839: Patch
https://bugs.webkit.org/attachment.cgi?id=168839&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168839&action=review


This is getting closer - however this should be an enum that gets passed along
updateContents, not a bool member; Also this is not about directly composited
images, it's about whether BitmapTexture is allowed to modify the original
image. Something like enum UpdateContentsFlag {
UpdateCanModifyOriginalImageData = 0x01 }

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:76
> +void TextureMapperTile::updateContents(TextureMapper* textureMapper, Image*
image, const IntRect& dirtyRect, bool isDirectlyCompositedImage)

This is a boolean trap... it should be an enum, like ContentUpdateOptions

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:98
> +    if (isDirectlyCompositedImage)
> +	   m_texture->setDirectlyCompositedFlag();
>      m_texture->updateContents(image, targetRect, sourceOffset);
> +    if (isDirectlyCompositedImage)
> +	   m_texture->resetDirectlyCompositedFlag();

You don't really need this as a member. Pass it through the updateContents
functions instead.