[webkit-reviews] review granted: [Bug 99336] Web Inspector: [Elements] Double-click to live edit style tags changes text to 'undefined' in some situations : [Attachment 168939] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 99336: Web Inspector: [Elements] Double-click to live edit style tags
changes text to 'undefined' in some situations
https://bugs.webkit.org/show_bug.cgi?id=99336

Attachment 168939: Patch
https://bugs.webkit.org/attachment.cgi?id=168939&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168939&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1326
> +	       var node = this.representedObject;

I would rename textNode to textNodeElement  and node to textNode.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1331
>	   var config = new
WebInspector.EditingConfig(this._textNodeEditingCommitted.bind(this),
this._editingCancelled.bind(this));

You should bind textNode parameter for _textNodeEditingCommitted to avoid
duplicating the code in _textNodeEditingCommitted.