[webkit-reviews] review denied: [Bug 99461] Web Inspector: add timeline instrumentation for scrolling of a layer : [Attachment 168931] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 99461: Web Inspector: add timeline instrumentation for scrolling of a layer
https://bugs.webkit.org/show_bug.cgi?id=99461

Attachment 168931: Patch
https://bugs.webkit.org/attachment.cgi?id=168931&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168931&action=review


r- for didScroll vs didScrollLayer

> Source/WebCore/ChangeLog:8
> +	   - added timeline instrumentation for scrolling of a layer;

What does it give to the user? Is there a way to address scrolling slowness?

> Source/WebCore/inspector/InspectorInstrumentation.h:147
> +    static void didScrollLayer(Frame*);

What is the difference with didScroll ?

> Source/WebCore/inspector/InspectorTimelineAgent.h:111
> +    void willScroll(Frame*);

Nit: we should come up with more dense way of instrumenting simple signals.

> Source/WebCore/rendering/RenderLayer.cpp:1712
> +    InspectorInstrumentation::willScrollLayer(frame);

Is there a TRACE_EVENT for this? Should we start with tracing it there and add
it into the instrumentation if it proves to be valuable?