[webkit-reviews] review granted: [Bug 99455] [EFL][WK2] Inherit Ewk_Download_Job, Ewk_Back_Forward_List_Item, Ewk_Url_Response, Ewk_Navigation_Policy_Decision from RefCounted : [Attachment 168923] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 99455: [EFL][WK2] Inherit Ewk_Download_Job, Ewk_Back_Forward_List_Item,
Ewk_Url_Response, Ewk_Navigation_Policy_Decision from RefCounted
https://bugs.webkit.org/show_bug.cgi?id=99455

Attachment 168923: patch
https://bugs.webkit.org/attachment.cgi?id=168923&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168923&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:NaN
>  static inline Ewk_Back_Forward_List_Item* addItemToWrapperCache(const
Ewk_Back_F

it's internal, maybe we should return the PassRefPtr?

> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:51
> +    _Ewk_Navigation_Policy_Decision(WKFramePolicyListenerRef _listener,
Ewk_Navigation_Type _navigationType, Event_Mouse_Button _mouseButton,
Event_Modifier_Keys _modifiers, PassRefPtr<Ewk_Url_Request> _request, const
char* _frameName)

C++ doesnt require you to add _ here

: listener(listener) should work