[webkit-reviews] review granted: [Bug 99349] Bytecode should not have responsibility for determining how to perform non-local resolves : [Attachment 168762] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 99349: Bytecode should not have responsibility for determining how to
perform non-local resolves
https://bugs.webkit.org/show_bug.cgi?id=99349

Attachment 168762: Patch
https://bugs.webkit.org/attachment.cgi?id=168762&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
My one major concern was the DCE thing – could omitting inserting any node that
references base/value result in these values not being generated & handed back
out the the baseline JIT, in the cases this patch forceOSRExits.  Since I'm out
of office tomorrow, please discuss with Filip – if he agrees with you that this
is safe as is, r+.