[webkit-reviews] review granted: [Bug 98945] Web Inspector: Whitelist safe styles for 'console.log('%c...', ...)'. : [Attachment 168669] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 98945: Web Inspector: Whitelist safe styles for 'console.log('%c...',
...)'.
https://bugs.webkit.org/show_bug.cgi?id=98945

Attachment 168669: Patch
https://bugs.webkit.org/attachment.cgi?id=168669&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168669&action=review


> Source/WebCore/inspector/front-end/ConsoleMessage.js:463
> +	       if (property === "color" || property === "font")

No need to special case these: font will match below, color could be also added
below - it'll break when there is a new color-* something introduced :)

> Source/WebCore/inspector/front-end/ConsoleMessage.js:468
> +		   if (property.substr(0, prefixes[i].length) == prefixes[i])

property.startsWith(prefixes[i])