[webkit-reviews] review granted: [Bug 99370] Inspector: Don't trip assert when inspecting an empty db : [Attachment 168787] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 99370: Inspector: Don't trip assert when inspecting an empty db
https://bugs.webkit.org/show_bug.cgi?id=99370

Attachment 168787: Patch
https://bugs.webkit.org/attachment.cgi?id=168787&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168787&action=review


>> Source/WebCore/inspector/front-end/ResourcesPanel.js:1659
>> +	    // FIXME: Why does this happen sometimes?
> 
> But since IDB is async and this._database is populated in update() in
response to _indexedDBLoaded() firing, perhaps the selection can be set earlier
programmatically?
> 
> (This is really a question for the Inspector folks.)

This is just hiding the manifestation of the problem without fixing it. Please
revert before landing.

I filed https://bugs.webkit.org/show_bug.cgi?id=99434 for that issue, I can fix
it myself.