[webkit-reviews] review granted: [Bug 99358] Rename some AudioNodes : [Attachment 168801] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 15 21:59:04 PDT 2012
Daniel Bates <dbates at webkit.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 99358: Rename some AudioNodes
https://bugs.webkit.org/show_bug.cgi?id=99358
Attachment 168801: Patch
https://bugs.webkit.org/attachment.cgi?id=168801&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168801&action=review
Please sort the file listing in the Xcode project file such that the files are
listed according to the Unix sort command.
> Source/WebCore/ChangeLog:37
> + (WebCore):
> + (WebCore::AnalyserNode::AnalyserNode):
> + (WebCore::AnalyserNode::~AnalyserNode):
> + (WebCore::AnalyserNode::process):
> + (WebCore::AnalyserNode::reset):
> + (WebCore::AnalyserNode::setFftSize):
We tend to omit the function listings when we rename a file since the functions
have not actually changed. Omitting such listings will also decrease the length
of the change log/commit message.
More information about the webkit-reviews
mailing list