[webkit-reviews] review granted: [Bug 99375] Add force parameter to DOMTokenList.toggle : [Attachment 168797] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 20:38:55 PDT 2012


Darin Adler <darin at apple.com> has granted Pablo Flouret <pablof at motorola.com>'s
request for review:
Bug 99375: Add force parameter to DOMTokenList.toggle
https://bugs.webkit.org/show_bug.cgi?id=99375

Attachment 168797: Patch
https://bugs.webkit.org/attachment.cgi?id=168797&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Code change looks fine. Test cases are not nearly extensive enough. We should
do the toggle version of all the add and remove tests, plus we need to check
the behavior when the argument is a non-boolean JavaScript value such as the
numbers 0 and 1, null, undefined, or a string.


More information about the webkit-reviews mailing list