[webkit-reviews] review granted: [Bug 99363] StringImpl::reverseFind() with a single match character isn't optimal for mixed 8/16 bit cases : [Attachment 168832] Patch with review updates

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 99363: StringImpl::reverseFind() with a single match character isn't
optimal for mixed 8/16 bit cases
https://bugs.webkit.org/show_bug.cgi?id=99363

Attachment 168832: Patch with review updates
https://bugs.webkit.org/attachment.cgi?id=168832&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168832&action=review


> Source/WTF/wtf/text/StringImpl.h:1015
> +ALWAYS_INLINE size_t reverseFind(const UChar* characters, unsigned length,
LChar matchCharacter, unsigned index = 0)

default value of index looks wrong.

> Source/WTF/wtf/text/StringImpl.h:1020
> +inline size_t reverseFind(const LChar* characters, unsigned length, UChar
matchCharacter, unsigned index = 0)

Ditto.