[webkit-reviews] review granted: [Bug 95792] WebAudio: limit output level to 0db : [Attachment 168771] Patch

[bugzilla-daemon at webkit.org]

Chris Rogers <crogers at google.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 95792: WebAudio: limit output level to 0db
https://bugs.webkit.org/show_bug.cgi?id=95792

Attachment 168771: Patch
https://bugs.webkit.org/attachment.cgi?id=168771&action=review

------- Additional Comments from Chris Rogers <crogers at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168771&action=review


Looks fine to me with some small nits.

> Source/WebCore/ChangeLog:12
> +	   >0db buffers and effects.

I'd update the ChangeLog comment here

> Source/WebCore/platform/audio/VectorMath.cpp:115
> +void vclip(const float * sourceP, int sourceStride, const float*
lowThresholdP, const float* highThresholdP, float* destP, int destStride,
size_t framesToProcess)

style nit: "float *" -> "float*"

> Source/WebCore/platform/audio/VectorMath.cpp:651
> +void vclip(const float * sourceP, int sourceStride, const float*
lowThresholdP, const float* highThresholdP, float* destP, int destStride,
size_t framesToProcess)

style nit: "float *" -> "float*"

> Source/WebCore/platform/audio/VectorMath.h:53
> +void vclip(const float * sourceP, int sourceStride, const float*
lowThresholdP, const float* highThresholdP, float* destP, int destStride,
size_t framesToProcess);

style nit: "float *" -> "float*"

> ManualTests/webaudio/limit-level-0db.html:36
> +    </p>

Maybe update comment - Strictly speaking, you'll hear the "clipping", thus the
sine wave will be clipped into the form of a square wave, but it shouldn't get
radically louder than the full-scale sine wave