[webkit-reviews] review denied: [Bug 99297] should make plugin process debugging easier (PLUGIN_PROCESS_CMD_PREFIX) : [Attachment 168653] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Jussi Kukkonen (jku)
<jussi.kukkonen at intel.com>'s request for review:
Bug 99297: should make plugin process debugging easier
(PLUGIN_PROCESS_CMD_PREFIX)
https://bugs.webkit.org/show_bug.cgi?id=99297

Attachment 168653: Patch
https://bugs.webkit.org/attachment.cgi?id=168653&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168653&action=review


> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:82
> +    const char* cmdPrefix = getenv("PLUGIN_PROCESS_CMD_PREFIX");
> +    if (cmdPrefix && *cmdPrefix)
> +	   launchOptions.processCmdPrefix = String::fromUTF8(cmdPrefix);
> +#endif

Won't this break non-EFL builds since they don't have the
launchOptions.processCmdPrefix member.	I would prefer if you clean this up by
adding platformInitializeLaunchOptions() that is implemented separately.