[webkit-reviews] review denied: [Bug 84885] [Resource Timing] Implement buffer limits : [Attachment 161955] Patch

Mon Oct 15 15:39:59 PDT 2012

Tony Gentilcore <tonyg at chromium.org> has denied pdeng6 <pan.deng at intel.com>'s
request for review:
Bug 84885: [Resource Timing] Implement buffer limits
https://bugs.webkit.org/show_bug.cgi?id=84885

Attachment 161955: Patch
https://bugs.webkit.org/attachment.cgi?id=161955&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161955&action=review

r- for the issues raised by simonjam. This is looking close, just needs a
little more work.

> Source/WebCore/ChangeLog:3
> +	   [Resource Timing]Implementation of reource timing buffer size
restriction functionality

s/reourse/resource/

>
LayoutTests/http/tests/w3c/webperf/proposal/resource-timing/test_resource_timin
g_buffer_size_restriction.html:25
> +	   <iframe id="frameContext" onload=onload_test()
src="/w3c/webperf/resources/blank_page_green.htm" style="width: 250px; height:
250px;"></iframe>

These three tests don't look like they need to have an iframe. Could you please
simplifying them and just put the onload handler in <body>.