[webkit-reviews] review granted: [Bug 99207] truncated-direct-png-image.html should not be a reftest : [Attachment 168482] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 12:53:19 PDT 2012


Eric Seidel <eric at webkit.org> has granted Nick Carter <nick at chromium.org>'s
request for review:
Bug 99207: truncated-direct-png-image.html should not be a reftest
https://bugs.webkit.org/show_bug.cgi?id=99207

Attachment 168482: Patch
https://bugs.webkit.org/attachment.cgi?id=168482&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168482&action=review


> LayoutTests/compositing/images/truncated-direct-png-image.html:21
> +	 document.getElementById('layers').innerText =
window.internals.layerTreeAsText(document);

textContent is the more modern innerText equivalent. :)

> LayoutTests/compositing/images/truncated-direct-png-image.html:32
> +The layer tree goes here in DRT.

Maybe this should say FAIL in it, as it would be a failure if the JS didn't
run.


More information about the webkit-reviews mailing list