[webkit-reviews] review granted: [Bug 99348] Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet : [Attachment 168752] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 99348: Add computeLogicalHeight override methods to RenderView and
RenderMultiColumnSet
https://bugs.webkit.org/show_bug.cgi?id=99348

Attachment 168752: Patch
https://bugs.webkit.org/attachment.cgi?id=168752&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168752&action=review


> Source/WebCore/rendering/RenderMultiColumnSet.cpp:69
>  void RenderMultiColumnSet::updateLogicalHeight()
>  {
>      // Make sure our column height is up to date.

FIXME maybe? To point out that this is the last method to be removed in order
to make updateLogicalHeight non-virtual?