[webkit-reviews] review canceled: [Bug 99309] Web Inspector: convert manual size calculation of different WebKit things into MemoryInstrumentation. : [Attachment 168685] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 10:32:11 PDT 2012


Hans Muller <giles_joplin at yahoo.com> has canceled Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 99309: Web Inspector: convert manual size calculation of different WebKit
things into MemoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=99309

Attachment 168685: Patch
https://bugs.webkit.org/attachment.cgi?id=168685&action=review

------- Additional Comments from Hans Muller <giles_joplin at yahoo.com>
Added FloatRect::extend() to simplify writing loops that accumulate the
bounding box for a sequence of vertices.  For example:

FloatRect box(vertices[0], FloatSize(0,0));
for (unsigned i = 1; i < vertices.length; i++)
    box.extend(vertices[i]);

ExclusionShape and ExclusionPolygon now use FloatRect::extend().


More information about the webkit-reviews mailing list