[webkit-reviews] review canceled: [Bug 98874] [GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages : [Attachment 168190] Patch updated to current git master

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 98874: [GTK] WebKitWebView doesn't notify of favicon changes for known
favicons but new pages
https://bugs.webkit.org/show_bug.cgi?id=98874

Attachment 168190: Patch updated to current git master
https://bugs.webkit.org/attachment.cgi?id=168190&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Patch updated to add a change suggested by Mario, because unit tests didn't
pass for him. The idea is to wait until there's an icon record in the database
to emit favicon-changed. For some reason I don't need this to make unit tests
pass, but it's a good idea in any case.