[webkit-reviews] review denied: [Bug 99188] Incorrect keycodes for numpad /, -, +, . : [Attachment 168604] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 99188: Incorrect keycodes for numpad /, -, +, .
https://bugs.webkit.org/show_bug.cgi?id=99188

Attachment 168604: Patch
https://bugs.webkit.org/attachment.cgi?id=168604&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168604&action=review


The change makes sense.

Please add WebKitTestRunner and DumpRenderTree tests - there are similar ones
already.

> Source/WebKit/chromium/ChangeLog:8
> +		   In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key
codes. This CL fixes this by never mapping numpad keys by character code.

Too many spaces here.