[webkit-reviews] review requested: [Bug 99309] Web Inspector: convert manual size calculation of different WebKit things into MemoryInstrumentation. : [Attachment 168685] Patch

[bugzilla-daemon at webkit.org]

Alexei Filippov <alph at chromium.org> has asked  for review:
Bug 99309: Web Inspector: convert manual size calculation of different WebKit
things into MemoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=99309

Attachment 168685: Patch
https://bugs.webkit.org/attachment.cgi?id=168685&action=review

------- Additional Comments from Alexei Filippov <alph at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168685&action=review


> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:-479
> -		       unusedSize -= child.children[j].size;

Why do you need this *.Unused record? What's wrong with calculating it? What's
if *.Unused is not present? It seems that unusedSize will be zero, e.g. for
JSHeap.