[webkit-reviews] review denied: [Bug 97980] Console messages containing long URLs should cut at some reasonable length. : [Attachment 167601] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 04:28:45 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Mike West
<mkwst at chromium.org>'s request for review:
Bug 97980: Console messages containing long URLs should cut at some reasonable
length.
https://bugs.webkit.org/show_bug.cgi?id=97980

Attachment 167601: Patch
https://bugs.webkit.org/attachment.cgi?id=167601&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167601&action=review


> Source/WebCore/inspector/front-end/ResourceUtils.js:172
> +    classes += " linkifiedURL";

No need for the new class, you could use webkit-html-external-link,
webkit-html-resource-link classes instead.

> Source/WebCore/inspector/front-end/inspector.css:1023
> +#console-messages a.linkifiedURL {

I wonder if we should explicitly trimMiddle instead and limit the url to say
200 characters. WDYT? You should also assign a title (tooltip) for the
potentially trimmed url.


More information about the webkit-reviews mailing list