[webkit-reviews] review denied: [Bug 97651] [EFL] Make PageClient accessible to both WebKit and WebKit2 : [Attachment 168637] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 02:09:55 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Regina Chung
<heejin.r.chung at samsung.com>'s request for review:
Bug 97651: [EFL] Make PageClient accessible to both WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=97651

Attachment 168637: Patch
https://bugs.webkit.org/attachment.cgi?id=168637&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
This seems like a terrible abuse of the page client. The page client is not
supposed to be reused across ports. It is something that is very specific to
the client of the page (aka view/viewport!) and something that is specific to
each port. This moved in the wrong direction of what the page client was
created for.


More information about the webkit-reviews mailing list