[webkit-reviews] review granted: [Bug 99087] [EFL][WK2] Implement Favicons API : [Attachment 168643] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 99087: [EFL][WK2] Implement Favicons API
https://bugs.webkit.org/show_bug.cgi?id=99087

Attachment 168643: Patch
https://bugs.webkit.org/attachment.cgi?id=168643&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168643&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp:205
> +    Evas_Object* icon = response->surface ?
WebCore::evasObjectFromCairoImageSurface(response->callbackData.evas,
response->surface.get()) : 0;

RefPtr? Evas_Object should support it

> Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp:229
> +    // If there's not a valid icon, but there's an iconURL registered,

If there is no valid icon?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:100
> +    while (!iconChanged)
> +	   ecore_main_loop_iterate();

newline after this

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:156
> +    while (!data.icon)
> +	   ecore_main_loop_iterate();

newline

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:57
> +    return String::fromUTF8(efreet_data_home_get()) +
"/WebKitEfl/IconDatabase";

so I suppose this is a hidden dir?