[webkit-reviews] review granted: [Bug 98589] [EFL][WK2] Provide implementation for PageClientImpl::toolTipChanged() : [Attachment 168632] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 98589: [EFL][WK2] Provide implementation for
PageClientImpl::toolTipChanged()
https://bugs.webkit.org/show_bug.cgi?id=98589

Attachment 168632: Patch
https://bugs.webkit.org/attachment.cgi?id=168632&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168632&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1131
> + * Reports that the tooltip text was changed.
> + *
> + * Emits signal: "tooltip,text,set" with a tooltip text to set.
> + *		    "tooltip,text,unset" if tooltip must be actually removed.

I dont think we normally have to document internal methods. Internal methods
tend to change so documentation becomes stale