[webkit-reviews] review denied: [Bug 99168] Add tests for suggestion picker that test step/min/max attributes : [Attachment 168618] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 14 21:01:03 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 99168: Add tests for suggestion picker that test step/min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=99168

Attachment 168618: Patch
https://bugs.webkit.org/attachment.cgi?id=168618&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168618&action=review


>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-pick
er-min-max-attribute.html:35
> +    popupWindow.removeEventListener("resize", test, false);

removeEventListener is unnecessary.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-pick
er-step-attribute.html:33
> +    popupWindow.addEventListener("resize", test1, false);

addEventListener is unnecessary.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/time-suggestion-pick
er-min-max-attribute.html:32
> +    popupWindow.removeEventListener("resize", test, false);

removeEventListener is unnecessary.


More information about the webkit-reviews mailing list