[webkit-reviews] review granted: [Bug 98733] [WK2] Add CustomFilterOperation serialization in ArgumentCoder. : [Attachment 168595] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 98733: [WK2] Add CustomFilterOperation serialization in ArgumentCoder.
https://bugs.webkit.org/show_bug.cgi?id=98733

Attachment 168595: Patch
https://bugs.webkit.org/attachment.cgi?id=168595&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168595&action=review


Great!
Please fix nit-picks before committing...

> Source/WebKit2/ChangeLog:10
> +	   Coordinated Graphics will use this css shaders serialization when it
enables CSS
> +	   Shaders.

Please remove these lines.

> Source/WebKit2/ChangeLog:30
> +	       WebCustomFilterProgram is made from serialized data of
> +	       StyleCustomFilterProgram in UI Process. UI Process uses this
class
> +	       instead of StyleCustomFilterProgram because UI Process can not
get a
> +	       custom filter program via network.

Just say "WebCustomFilterProgram is made to serialize the data of a
StyleCustomFilterProgram to the UI process."

>
Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
:29
> +#if USE(COORDINATED_GRAPHICS)

Put this line after the main include

>
Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
:150
> +		   encoder->encode(parameters[i]->name());
> +		   encoder->encodeEnum(parameters[i]->parameterType());

Please save parameters[i] in a local variable.