[webkit-reviews] review granted: [Bug 99218] [WK2] Add SharedWorkerProcess : [Attachment 168515] proposed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 99218: [WK2] Add SharedWorkerProcess
https://bugs.webkit.org/show_bug.cgi?id=99218

Attachment 168515: proposed patch
https://bugs.webkit.org/attachment.cgi?id=168515&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168515&action=review


I'd love to see this share more code, but looks good.

> Source/WebKit2/Shared/SharedWorkerProcessCreationParameters.h:33
> +#if PLATFORM(MAC)
> +#include "MachPort.h"
> +#endif

This does not seem to be used.

> Source/WebKit2/SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:71
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070
> +    initializeSandbox();
> +#endif

This is not an ideal place to initialize the sandbox. Instead, it should
initialized directly from main as we do for the WebProcess.