[webkit-reviews] review granted: [Bug 99113]=?UTF-8?Q?=20Font=E2=80=99s=20fast=20code=20path=20doesn=E2=80=99t=20support=20kerning=20and=20ligatures=20?=: [Attachment 168465] Add kerning and ligature support on the fast code path (this patch excludes WebKitLibraries changes)

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 99113: Font’s fast code path doesn’t support kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=99113

Attachment 168465: Add kerning and ligature support on the fast code path (this
patch excludes WebKitLibraries changes)
https://bugs.webkit.org/attachment.cgi?id=168465&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168465&action=review


> Source/WebCore/platform/graphics/WidthIterator.cpp:104
> +static inline float applyFontTransforms(GlyphBuffer* glyphBuffer, bool ltr,
int& lastGlyphCount, const SimpleFontData* fontData, TypesettingFeatures
typesettingFeatures, CharactersTreatedAsSpace& charactersTreatedAsSpace)

Do we not have/use an enum for writing direction?

> Source/WebCore/platform/graphics/WidthIterator.cpp:130
> +    if (!ltr) {
> +	   for (int i = 0, end = glyphBuffer->size() - 1; i <
glyphBuffer->size() / 2; ++i, --end)
> +	       glyphBuffer->swap(i, end);
> +    }

DRY? There's so little code here though, I guess it's ok.