[webkit-reviews] review granted: [Bug 99214] Teach GeneratorGObject about [ImplementedAs] extended attribute in functions : [Attachment 168502] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 99214: Teach GeneratorGObject about [ImplementedAs] extended attribute in
functions
https://bugs.webkit.org/show_bug.cgi?id=99214

Attachment 168502: Patch
https://bugs.webkit.org/attachment.cgi?id=168502&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168502&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:979
> +    my $functionImplementationName =
$function->signature->extendedAttributes->{"ImplementedAs"} ||
$function->signature->name;

Nit: You can use $functionSigName instead of $function->signature->name. Or you
can remove $functionSigName since it is not used so much.