[webkit-reviews] review granted: [Bug 99116] [RequestAnimationFrame] Remove vendor prefix : [Attachment 168457] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 12 12:01:17 PDT 2012


Adam Barth <abarth at webkit.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 99116: [RequestAnimationFrame] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=99116

Attachment 168457: Patch
https://bugs.webkit.org/attachment.cgi?id=168457&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168457&action=review


> Source/WebCore/page/DOMWindow.idl:220
> +    long requestAnimationFrame(in [Callback] RequestAnimationFrameCallback
callback);
> +    void cancelAnimationFrame(in long id);
> +    [ImplementedAs=requestAnimationFrame,
V8MeasureAs=PrefixedRequestAnimationFrame] long webkitRequestAnimationFrame(in
[Callback] RequestAnimationFrameCallback callback);
> +    [ImplementedAs=cancelAnimationFrame] void webkitCancelAnimationFrame(in
long id);
> +    [ImplementedAs=cancelAnimationFrame] void
webkitCancelRequestAnimationFrame(in long id); // This is a deprecated alias
for webkitCancelAnimationFrame(). Remove this when removing vendor prefix.

Should we measure the unprefixed one as well, so we can compare, like we do for
IndexedDB?


More information about the webkit-reviews mailing list