[webkit-reviews] review granted: [Bug 99080] MediaStream API: Implement RTCDataChannel : [Attachment 168386] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 99080: MediaStream API: Implement RTCDataChannel
https://bugs.webkit.org/show_bug.cgi?id=99080

Attachment 168386: Patch
https://bugs.webkit.org/attachment.cgi?id=168386&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168386&action=review


This looks great.  We just need to make sure it still compiles w.r.t. the IDL
parser change last night.

> Source/WebCore/Modules/mediastream/RTCDataChannel.idl:28
> +interface [
> +    Conditional=MEDIA_STREAM,
> +    EventTarget
> +] RTCDataChannel {

We're working on making WebKitIDL more like WebIDL, so we might need to move
these attributes before the keyword "interface"