[webkit-reviews] review requested: [Bug 91854] [WK2][EFL] Implementation of spellchecking feature. : [Attachment 168409] reduce implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 12 06:03:37 PDT 2012
Grzegorz Czajkowski <g.czajkowski at samsung.com> has asked for review:
Bug 91854: [WK2][EFL] Implementation of spellchecking feature.
https://bugs.webkit.org/show_bug.cgi?id=91854
Attachment 168409: reduce implementation
https://bugs.webkit.org/attachment.cgi?id=168409&action=review
------- Additional Comments from Grzegorz Czajkowski <g.czajkowski at samsung.com>
1. Remove 'grammar checking settings'.
It doesn't make sense to export API which allows to enable 'grammar
checking' if the core implementation is missing.
2. Move spelling settings to the ewk_setting.{h,cpp} files.
The files mostly manipulate settings which are related to the view object.
Text checker settings (in fact spelling settings) are not connected to any view
object but keeping them somewhere else may be confusing.
3. ewk_text_checker_settings.{h,cpp} is no needed any more :)
More information about the webkit-reviews
mailing list