[webkit-reviews] review denied: [Bug 88606] [Shadow DOM] Needs @host rule for ShadowDOM styling : [Attachment 168155] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 88606: [Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606

Attachment 168155: Patch
https://bugs.webkit.org/attachment.cgi?id=168155&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168155&action=review


> Source/WebCore/css/RuleSet.h:50
> +    RuleData(StyleRule*, unsigned selectorIndex, unsigned position, unsigned
addRuleState);

Coud you use AddRuleState instead of unsigned?

> Source/WebCore/css/StyleResolver.cpp:438
> +void StyleResolver::addHostRule(StyleRuleHost* hostRule, bool
hasDocumentSecurityOrigin, const ContainerNode* scope)

Can we move this implementation more to StyleScopeResolver?
Ideally all @host related code should be owned by StyleScopeResolver.
I know it's unfeasible for now. But I think we could be better here.

> Source/WebCore/css/StyleResolver.cpp:440
> +#if ENABLE(STYLE_SCOPED)

This isn't related STYLE_SCOPED. This should be part of SHAODW_ROOT.

> Source/WebCore/css/StyleResolver.cpp:781
> +#if ENABLE(STYLE_SCOPED)

Ditto.

> Source/WebCore/css/StyleResolver.cpp:790
> +#if ENABLE(STYLE_SCOPED)

Ditto.