[webkit-reviews] review denied: [Bug 98000] [WebSocket] Add "Cache-Control: no-cache" to handshake request : [Attachment 168365] Patch

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 98000: [WebSocket] Add "Cache-Control: no-cache" to handshake request
https://bugs.webkit.org/show_bug.cgi?id=98000

Attachment 168365: Patch
https://bugs.webkit.org/attachment.cgi?id=168365&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168365&action=review


> Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:215
> +

You need to add these headers in clientHandshakeRequest() function, too. Web
Inspecter will use
it to display request headers.

> LayoutTests/http/tests/websocket/tests/hybi/nocache-expected.txt:8
> +FAIL closeEvent.wasClean should be true. Threw exception ReferenceError:
closeEvent is not defined

This needs to be fixed.