[webkit-reviews] review denied: [Bug 99131] IndexedDB: use auxiliary v8 context for deserialization : [Attachment 168349] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 21:36:48 PDT 2012


Adam Barth <abarth at webkit.org> has denied David Grogan <dgrogan at chromium.org>'s
request for review:
Bug 99131: IndexedDB: use auxiliary v8 context for deserialization
https://bugs.webkit.org/show_bug.cgi?id=99131

Attachment 168349: Patch
https://bugs.webkit.org/attachment.cgi?id=168349&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168349&action=review


> Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:218
>      return ScriptValue(prpValue->deserialize());

Won't this generate JavaScript objects with incorrect prototype chains (i.e.,
pointing to Object.prototyp from the auxiliary context)?


More information about the webkit-reviews mailing list