[webkit-reviews] review granted: [Bug 99122] LocalCurrentGraphicsContext will never restore the current context to null : [Attachment 168327] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 99122: LocalCurrentGraphicsContext will never restore the current context
to null
https://bugs.webkit.org/show_bug.cgi?id=99122

Attachment 168327: patch
https://bugs.webkit.org/attachment.cgi?id=168327&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168327&action=review


> Source/WebCore/ChangeLog:12
> +	   LocalCurrentGraphicsContext is meant to cause temporary changes to
> +	   NSGraphicsContext's currentContext. However, if it is entered when
> +	   currentContext is null, it will not restore to null, as a null
> +	   m_savedNSGraphicsContext was being used to indicate that the current
and
> +	   passed-in graphics contexts were equal (and thus no save/restore was
required).

You should also mentiong flipping the order of the restores.