[webkit-reviews] review denied: [Bug 98422] [TestResultServer] Add support for non-Chromium TestExpectations files : [Attachment 168189] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 98422: [TestResultServer] Add support for non-Chromium TestExpectations
files
https://bugs.webkit.org/show_bug.cgi?id=98422

Attachment 168189: Patch
https://bugs.webkit.org/attachment.cgi?id=168189&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168189&action=review


This looks great. Just a few more tests if you don't mind.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:425
> +var TestTrie = function()

How about taking builders as an argument to the constructor instead? Then you
can easily test this by passing in a more manageable object and pass in
g_builders in the actual code.

Mind adding some tests for this? Shouldn't be too hard to get good test
coverage of all the code paths.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:885
> +    logTime('processExpectations: ', start);

Nit: please remove this and the start variable.