[webkit-reviews] review granted: [Bug 99117] Move TransformState code into its own member function, and remove a test that was prematurely added : [Attachment 168315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 16:48:48 PDT 2012


Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 99117: Move TransformState code into its own member function, and remove a
test that was prematurely added
https://bugs.webkit.org/show_bug.cgi?id=99117

Attachment 168315: Patch
https://bugs.webkit.org/attachment.cgi?id=168315&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168315&action=review


> Source/WebCore/ChangeLog:8
> +	   The code that manipulates the TransormState and computes the visible
rect is going to get

typo Transform

> Source/WebCore/ChangeLog:11
> +	   Remove a test that wasn't supposed to be added yet.

Unclear why these are in the same patch. (what would happen if someone wanted
to roll out the TransformState change?)

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:950
> +    // Save the state before sending down to kids and restore it after

Punctuation.


More information about the webkit-reviews mailing list