[webkit-reviews] review granted: [Bug 99084] [Chromium-Android] Exception when the layout test driver is stopped : [Attachment 168254] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 99084: [Chromium-Android] Exception when the layout test driver is stopped
https://bugs.webkit.org/show_bug.cgi?id=99084

Attachment 168254: Patch
https://bugs.webkit.org/attachment.cgi?id=168254&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168254&action=review


This seems reasonable. One

> Tools/Scripts/webkitpy/layout_tests/port/server_process.py:334
>	   self._proc.stdin.close()

Can you add a "self._proc.stdin = None" here as well? I think w/o this we can
end up trying to close the handle twice in self._reset() on line 357 (this
isn't your fault, but I noticed this while reviewing the patch).