[webkit-reviews] review granted: [Bug 98979] [Chromium] Improve vertical text rendering of HarfBuzzShaper : [Attachment 168124] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 98979: [Chromium] Improve vertical text rendering of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=98979

Attachment 168124: Patch
https://bugs.webkit.org/attachment.cgi?id=168124&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168124&action=review


> Source/WebCore/ChangeLog:16
> +	   (WebCore::findScriptForVerticalGlyphSubstitution): Added/

Nit: / instead of .

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:103
> +    static const hb_tag_t vertTag = HB_TAG('v', 'e', 'r', 't');
> +    static const hb_tag_t vrt2Tag = HB_TAG('v', 'e', 't', '2');

Nit: It would be nice if we could share this definition.  Maybe make them
public static variables on HarfBuzzNGFace?