[webkit-reviews] review denied: [Bug 98893] Replace (typeof(x) != <>) with !(typeof(x) == <>) : [Attachment 168201] patch second attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 09:24:44 PDT 2012


Filip Pizlo <fpizlo at apple.com> has denied Valery Ignatyev
<valery.ignatyev at ispras.ru>'s request for review:
Bug 98893: Replace (typeof(x) != <>) with !(typeof(x) == <>)
https://bugs.webkit.org/show_bug.cgi?id=98893

Attachment 168201: patch second attempt
https://bugs.webkit.org/attachment.cgi?id=168201&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168201&action=review


> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1060
> +	   if (opcodeID == op_nstricteq)

This should be "else if"?


More information about the webkit-reviews mailing list