[webkit-reviews] review denied: [Bug 98923] Web Inspector: Enabling experiments tab in WebKit nightly. : [Attachment 168224] Patch for always enabling the experiments tab.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 08:51:06 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Mihai Balan
<mibalan at adobe.com>'s request for review:
Bug 98923: Web Inspector: Enabling experiments tab in WebKit nightly.
https://bugs.webkit.org/show_bug.cgi?id=98923

Attachment 168224: Patch for always enabling the experiments tab.
https://bugs.webkit.org/attachment.cgi?id=168224&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This will also enable experiments in Chrome. You should instead add
Preferences.experimentsEnabled and make it "true" in
WebCore/inspector/front-end/Settings.js and "false" in
WebKit/chromium/src/js/DevTools.js. This check will become
Preferences.experimentsEnabled || "experiments" in
WebInspector.queryParamsObject. I think it is fine to enable experiments on
stable versions given that Safari ships its proprietary front-end now.


More information about the webkit-reviews mailing list