[webkit-reviews] review denied: [Bug 99019] [GTK] REGRESSION(r131033): Favicons don't work in MiniBrowser : [Attachment 168228] Patch proposal

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 99019: [GTK] REGRESSION(r131033): Favicons don't work in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=99019

Attachment 168228: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=168228&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168228&action=review


> Tools/MiniBrowser/gtk/BrowserWindow.c:524
> +    // Enable the favicon database, by specifying the default directory.
> +   
webkit_web_context_set_favicon_database_directory(webkit_web_view_get_context(w
indow->webView), NULL);
> +

We don't want to do this for every window, since we are sharing the web
process, if would be better to do it only once in main.c before browser windows
are created.