[webkit-reviews] review granted: [Bug 80992] Web Inspector: provide a way to reload page with given script preprocessor. : [Attachment 167994] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 80992: Web Inspector: provide a way to reload page with given script
preprocessor.
https://bugs.webkit.org/show_bug.cgi?id=80992

Attachment 167994: Patch
https://bugs.webkit.org/attachment.cgi?id=167994&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167994&action=review


Please file bug on the issues raised by John.

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:122
> +	   v8::Local<v8::Context> context =
v8::Local<v8::Context>::New(m_utilityContext.get());

You should check for empty m_utilityContext here.

> Source/WebCore/inspector/Inspector.json:227
> +		       { "name": "scriptPreprocessor", "type": "string",
"optional": true, "description": "Script body that should evaluate to function
that will preprocess all the scripts before their compilation.", "hidden": true
}

Please describe the function signature.