[webkit-reviews] review granted: [Bug 98885] [GTK] It should be possible to disable favicons in WebKit2 GTK+ API : [Attachment 168171] Patch proposal

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 98885: [GTK] It should be possible to disable favicons in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=98885

Attachment 168171: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=168171&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168171&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:407
> + * Get the #WebKitFaviconDatabase associated with @context

@context.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:412
> + * Notice that this method simply returns the #WebKitFaviconDatabase,
> + * but doesn't enable the database. To enable it you will still need to
> + * call webkit_web_context_set_favicon_database_directory() at least
> + * once, either before or after calling this method.

I think I would avoid using enable/disable, because the error you get from the
favicon database is NOT_INITIALIZED. I would simplify this by something like. 

"To initialize the database you need to call
webkit_web_context_set_favicon_database_directory()."